Skip to content

Add Fabric Component Props under API and Separate Old/New Components Section#1024

Closed
anupriya13 wants to merge 12 commits into
microsoft:mainfrom
anupriya13:user/anuverma/websiteUpdate
Closed

Add Fabric Component Props under API and Separate Old/New Components Section#1024
anupriya13 wants to merge 12 commits into
microsoft:mainfrom
anupriya13:user/anuverma/websiteUpdate

Conversation

@anupriya13

@anupriya13 anupriya13 commented Apr 18, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

  • Separates Old and New Arch Components Sections
  • Adds Fabric Component Props under New API for Windows.
    It doesn't contain Android / IOS specific props.

Why

What is the motivation for this change? Add a few sentences describing the context and overall goals of the pull request's commits.
Improve documentation

Resolves #1025

Refer https://github.com/facebook/react-native-website/blob/main/docs/image.md?plain=1

Screenshots

Add any relevant screen captures here from before or after your changes.
Before:

Recording.2025-04-19.234032.mp4

After: Added a new section which was missing in before "Windows Components - New Architecture"

website-new-vid.mp4
Microsoft Reviewers: Open in CodeFlow

@anupriya13 anupriya13 requested a review from a team as a code owner April 18, 2025 08:16
@anupriya13

anupriya13 commented Apr 18, 2025

Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree company="Microsoft"

@anupriya13 anupriya13 added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request website Issues with the website infrastructure labels Apr 18, 2025
@anupriya13 anupriya13 linked an issue Apr 18, 2025 that may be closed by this pull request
Old Arch only documentation should be moved into their own section in the sidebar #1015
Closed
@anupriya13 anupriya13 changed the title [0.79] Add Image Component Props under API [0.79] Add Image Component Props under API and Separate Old/New Components Section Apr 18, 2025
@anupriya13 anupriya13 mentioned this pull request Apr 18, 2025
Closed
@anupriya13 anupriya13 changed the title [0.79] Add Image Component Props under API and Separate Old/New Components Section [0.79] [Draft] Add Fabric Component Props under API and Separate Old/New Components Section Apr 18, 2025
@Yajur-Grover

Yajur-Grover commented Apr 18, 2025

Copy link
Copy Markdown
Contributor

Couple of small things:

  • In the sidebar, the titles of the Old and New Arch sections could be changed to just be 'Components - New Architecture' and 'Components - Old Architecture'. The 'Windows' part is not necessary since it's the React Native for Windows website.
  • Some of the components that you have put in the New Architecture section are also present in Old Architecture, which may cause some confusion for newer users of React Native Windows. Maybe it might make sense to have a list of Core components that are present in (or planned to be present in) both Old and New Architecture, and then a section for Old Arch only components, and one for New Arch only components.

TatianaKapos
TatianaKapos reviewed Apr 18, 2025
View reviewed changes
Comment thread website/.unbroken_exclusions Outdated
!versioned_docs/version-0.76/native-api/*-api-windows*.md
!versioned_docs/version-0.77/native-api/*-api-windows*.md
!versioned_docs/version-0.78/native-api/*-api-windows*.md
!versioned_docs/version-0.79/native-api/*-api-windows*.md

@TatianaKapos TatianaKapos Apr 18, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah this is good question! We don't want to cut these documents yet, RNW 0.79 isn't released yet. Instead, this should just be changed in the next documentation (main) and we will create the 0.79 version-docs as part of the release process

@anupriya13 anupriya13 Apr 19, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed them. Please review.

TatianaKapos
TatianaKapos reviewed Apr 18, 2025
View reviewed changes
Comment thread website/.unbroken_exclusions Outdated
TatianaKapos
TatianaKapos reviewed Apr 18, 2025
View reviewed changes
Comment thread website/versioned_docs/version-0.79/getting-started.md Outdated
TatianaKapos
TatianaKapos requested changes Apr 18, 2025
View reviewed changes

@TatianaKapos TatianaKapos left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We aren't ready to cut the 0.79 documentation, any changes/added documentation should be in the docs folder

@anupriya13

anupriya13 commented Apr 19, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Couple of small things:

  • In the sidebar, the titles of the Old and New Arch sections could be changed to just be 'Components - New Architecture' and 'Components - Old Architecture'. The 'Windows' part is not necessary since it's the React Native for Windows website.
  • Some of the components that you have put in the New Architecture section are also present in Old Architecture, which may cause some confusion for newer users of React Native Windows. Maybe it might make sense to have a list of Core components that are present in (or planned to be present in) both Old and New Architecture, and then a section for Old Arch only components, and one for New Arch only components.
  1. Sure, will update the titles, as this doc is for Mac as well hence will keep Windows.
  2. The reason I kept it as different is because each page of old and new would have different props, and when we want to depreciate the old one it would be easier. Helps us track exactly what props are implemented. Also, the old arch documentation is not complete, wouldn't want to add effort in updating that.
    Hence, keeping these 2 separate only for now. We can update in future after discussing with PMs.

@anupriya13 anupriya13 requested a review from TatianaKapos April 19, 2025 07:49
@anupriya13 anupriya13 changed the title [0.79] [Draft] Add Fabric Component Props under API and Separate Old/New Components Section Add Fabric Component Props under API and Separate Old/New Components Section Apr 19, 2025
@Yajur-Grover

Yajur-Grover commented Apr 21, 2025

Copy link
Copy Markdown
Contributor
  1. The reason I kept it as different is because each page of old and new would have different props, and when we want to depreciate the old one it would be easier. Helps us track exactly what props are implemented. Also, the old arch documentation is not complete, wouldn't want to add effort in updating that.
    Hence, keeping these 2 separate only for now. We can update in future after discussing with PMs.

Okay, maybe we can apply the suggestion from #1014 then, and mark each page depending on whether it is applicable to Old Arch, New Arch or both.

@anupriya13 anupriya13 linked an issue Apr 21, 2025 that may be closed by this pull request
Clearly tag each doc page as Old Arch / New Arch, or Needs Review #1014
Closed
chiaramooney
chiaramooney requested changes Apr 21, 2025
View reviewed changes

@chiaramooney chiaramooney left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking until design decision made about if we want to document all components instead of Windows-only.

@anupriya13 anupriya13 closed this Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chiaramooney chiaramooney chiaramooney requested changes

@acoates-ms acoates-ms Awaiting requested review from acoates-ms

@Yajur-Grover Yajur-Grover Awaiting requested review from Yajur-Grover

@TatianaKapos TatianaKapos Awaiting requested review from TatianaKapos

Assignees

No one assigned

Labels

bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request Needs: Attention 👋 website Issues with the website infrastructure

Projects

None yet

Milestone

No milestone

4 participants

@anupriya13 @Yajur-Grover @chiaramooney @TatianaKapos